This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Preference control misbehaves #164 & Moving forward on portability #169 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n portability eclipse-archived#169 Signed-off-by: Andrew Bowley <[email protected]> * Two new OS-specific packages org.eclipse.dartboard.os.linux/windows * New PlatformUtil class hides portability solution * New DartSdkChecker and SdkLocator classes support preferences access to SDK installations * SDKLocator (note different to SdkLocator) no longer needed, so removed * Solved preference field editor issues with executing shell command in validation eg. re-entry caused by SWT event handling * Improvements DartPreferencePageTest including new WaitCondition for transition from displaying error to clearing the error
|
Issues #164 and #172 are related because Dartboard preferences are the only feature which has to deal with portability. I evaluated the OS-specific fragments mentioned in #172, but decided that OS-specific packages are better suited to our current modest requirements. So a single OS branch in the PlatformUtil class determines whether to use the org.eclipse.dartboard.os.linux package or the org.eclipse.dartboard.os.windows package. |
|
I omitted to include this PR also includes the fix to 'tycho-maven-plugin:1.6.0-SNAPSHOT unresolved #171'. The version has been changed to 1.6.0. This update was essential to move forward with the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Bowley [email protected]
to SDK installations
validation eg. re-entry caused by SWT event handling
transition from displaying error to clearing the error