Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Empty Auth with personal access token #3148

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

ebuckle
Copy link
Contributor

@ebuckle ebuckle commented Jun 16, 2020

Signed-off-by: Edward Buckle [email protected]

What type of PR is this ?

  • Bug fix
  • Enhancement

What does this PR do ?

Returns an empty Authentication field when a repo is added with a personal access token. Allowing IDEs to pick up on repos that need them by looking for the empty field.

Which issue(s) does this PR fix ?

#3101

Link to the Codewind repository issue(s) this PR fixes or references:

Does this PR require a documentation change ?

No

Any special notes for your reviewer ?

None

@ebuckle ebuckle requested review from hhellyer and tobespc as code owners June 16, 2020 13:44
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #3148 into master will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   60.47%   60.46%   -0.02%     
==========================================
  Files         104      104              
  Lines       10769    10772       +3     
  Branches     1781     1783       +2     
==========================================
  Hits         6513     6513              
- Misses       4256     4259       +3     
Impacted Files Coverage Δ
src/pfe/portal/modules/Templates.js 96.95% <20.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202287b...fed1b8f. Read the comment docs.

Copy link
Contributor

@hhellyer hhellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should allow the UI plugins to tell the difference between no-auth and token based auth.

@hhellyer hhellyer merged commit a7abfe8 into eclipse-archived:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants