Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Remove hardcoded ignore list #499

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

ebuckle
Copy link
Contributor

@ebuckle ebuckle commented Jun 22, 2020

Signed-off-by: Edward Buckle [email protected]

What type of PR is this ?

  • Bug fix
  • Enhancement

What does this PR do ?

Removes the hard coded list of files to ignore when syncing projects. Ignore list is now only built from the files listed in cw-settings.

Which issue(s) does this PR fix ?

eclipse-archived/codewind#3138

Link to the Codewind repository issue(s) this PR fixes or references:

Does this PR require a documentation change ?

No

Any special notes for your reviewer ?

None

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #499 into master will decrease coverage by 0.46%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   19.82%   19.36%   -0.47%     
==========================================
  Files          81       81              
  Lines        7067     7029      -38     
==========================================
- Hits         1401     1361      -40     
- Misses       5496     5497       +1     
- Partials      170      171       +1     
Impacted Files Coverage Δ
pkg/project/sync.go 47.03% <33.33%> (-8.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83443e...59b6e12. Read the comment docs.

@tobespc tobespc self-assigned this Jun 24, 2020
Copy link
Contributor

@tobespc tobespc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with a node app and specifically with the node_modules directory. Before your change, node_modules was not copied over but with your change, that directory is being synched.

@ebuckle ebuckle force-pushed the ignoredFiles branch 2 times, most recently from decf4a5 to 313053b Compare June 24, 2020 15:37
Signed-off-by: Edward Buckle <[email protected]>
Copy link
Contributor

@tobespc tobespc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobespc tobespc merged commit a3dc753 into eclipse-archived:master Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants