ui: Save some user preferences to browser's local storage #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zustand [1] is a hook-based, lightweight state management solution with support for easy state persisting to for example browser's local storage. It is probably the easiest solution for saving some user's UI preferences to the browser, to improve the UX. [1]: https://zustand.docs.pmnd.rs/getting-started/introduction Signed-off-by: Jyrki Keisala <[email protected]>
Create a Zustand store hook for saving and persisting the user's page size preferences for the organizations, products, repositories and ORT runs data tables, with some sensible defaults. Signed-off-by: Jyrki Keisala <[email protected]>
As an example for using Zustand to handle and persist user preferences in the ORT Server UI, the organization data table's page size is handled as follows: - if the table preferences are not found from browser's local storage, default value for the page size of the table is used - when the user changes the page size of the table the first time, Zustand seamlessly persists the new chosen page size to browser's local storage - all subsequent changes to organization table's page size are persisted Signed-off-by: Jyrki Keisala <[email protected]>
Signed-off-by: Jyrki Keisala <[email protected]>
Signed-off-by: Jyrki Keisala <[email protected]>
Resolves #1954. Signed-off-by: Jyrki Keisala <[email protected]>
|
Issues referenced in commit messages and issues linked to this PR are not in sync. |
lamppu
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, user's choices for the page sizes of organizations, products, repositories and ORT runs data tables are seamlessly saved and persisted to browser's local storage, to improve the UX for ORT Server UI.
Please see the commits for details.