-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database): Remove entities orphaned with removing ort run #1937
Merged
oheger-bosch
merged 1 commit into
eclipse-apoapsis:main
from
boschglobal:delete-orphaned-entites-from-db
Feb 7, 2025
Merged
feat(database): Remove entities orphaned with removing ort run #1937
oheger-bosch
merged 1 commit into
eclipse-apoapsis:main
from
boschglobal:delete-orphaned-entites-from-db
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oheger-bosch
reviewed
Feb 3, 2025
b475dc4
to
b405b6b
Compare
161afb7
to
7d7b01a
Compare
351a29e
to
ac881eb
Compare
oheger-bosch
reviewed
Feb 7, 2025
dao/src/main/resources/db/migration/V93__projectsPackagesCascadeDelete.sql
Show resolved
Hide resolved
6f6e5ed
to
bcbf672
Compare
oheger-bosch
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor nits; otherwise looks good to me.
Do you have any estimate how long the single DELETE
statements will take for their execution?
dao/src/main/resources/db/migration/V93__projectsPackagesCascadeDelete.sql
Outdated
Show resolved
Hide resolved
dao/src/main/resources/db/migration/V93__projectsPackagesCascadeDelete.sql
Outdated
Show resolved
Hide resolved
During deletion of old / outdated ORT runs some of child database entities were left in DB. To prevent this situation, that leads to database performance issues, orphaned records are deleted. Deleted record types: - Packages - Projects - Authors - DeclaredLicenses - Identifiers - VCSInfo - RemoteArtifacts Signed-off-by: Kamil Bielecki <[email protected]>
bcbf672
to
72648b4
Compare
oheger-bosch
approved these changes
Feb 7, 2025
Merged
via the queue into
eclipse-apoapsis:main
with commit Feb 7, 2025
bbd5170
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When archive scans are removed from database, some of orphaned entities stays in database, just occupying space, and deteriorating performance. To prevent this, obsolete (orphaned) records are deleted.