Start untangling orchestrator #1739
+498
−175
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright (C) 2024 The ORT Server Authors (See <https://github.com/eclipse-apoapsis/ort-server/blob/main/NOTICE>) | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * License-Filename: LICENSE | ||
| */ | ||
|
|
||
| package org.eclipse.apoapsis.ortserver.orchestrator | ||
|
|
||
| import org.eclipse.apoapsis.ortserver.model.JobStatus | ||
|
|
||
| /** A class to store the required information to determine which jobs can be run. */ | ||
| internal class OrtRunInfo( | ||
| /** The ORT run ID. */ | ||
| val id: Long, | ||
|
|
||
| /** Whether the config worker has failed. */ | ||
| val configWorkerFailed: Boolean, | ||
|
|
||
| /** The jobs configured to run in this ORT run. */ | ||
| val configuredJobs: Set<WorkerScheduleInfo>, | ||
|
|
||
| /** Status information for already created jobs. */ | ||
| val jobInfos: Map<WorkerScheduleInfo, WorkerJobInfo> | ||
| ) { | ||
| /** Get the next jobs that can be run. */ | ||
| fun getNextJobs(): Set<WorkerScheduleInfo> = WorkerScheduleInfo.entries.filterTo(mutableSetOf()) { canRun(it) } | ||
|
|
||
| /** Return true if the job can be run. */ | ||
| private fun canRun(info: WorkerScheduleInfo): Boolean = | ||
| isConfigured(info) && | ||
| !wasScheduled(info) && | ||
| canRunIfPreviousJobFailed(info) && | ||
| info.dependsOn.all { isCompleted(it) } && | ||
| info.runsAfterTransitively.none { isPending(it) } | ||
|
|
||
| /** Return true if no previous job has failed or if the job is configured to run after a failure. */ | ||
| private fun canRunIfPreviousJobFailed(info: WorkerScheduleInfo): Boolean = info.runAfterFailure || !isFailed() | ||
|
|
||
| /** Return true if the job has been completed. */ | ||
| private fun isCompleted(info: WorkerScheduleInfo): Boolean = jobInfos[info]?.status?.final == true | ||
|
|
||
| /** Return true if the job is configured to run. */ | ||
| private fun isConfigured(info: WorkerScheduleInfo): Boolean = info in configuredJobs | ||
|
|
||
| /** Return true if any job has failed. */ | ||
| private fun isFailed(): Boolean = configWorkerFailed || jobInfos.any { it.value.status == JobStatus.FAILED } | ||
|
|
||
| /** Return true if the job is pending execution. */ | ||
| private fun isPending(info: WorkerScheduleInfo): Boolean = | ||
| isConfigured(info) && | ||
| !isCompleted(info) && | ||
| canRunIfPreviousJobFailed(info) && | ||
| info.dependsOn.all { wasScheduled(it) || isPending(it) } | ||
|
|
||
| /** Return true if the job has been scheduled. */ | ||
| private fun wasScheduled(info: WorkerScheduleInfo): Boolean = jobInfos.containsKey(info) | ||
| } | ||
|
|
||
| /** A class to store information of a worker job required by [OrtRunInfo]. */ | ||
| internal class WorkerJobInfo( | ||
| /** The job ID. */ | ||
| val id: Long, | ||
|
|
||
| /** The job status. */ | ||
| val status: JobStatus | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,346 @@ | ||
| /* | ||
| * Copyright (C) 2024 The ORT Server Authors (See <https://github.com/eclipse-apoapsis/ort-server/blob/main/NOTICE>) | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * License-Filename: LICENSE | ||
| */ | ||
|
|
||
| package org.eclipse.apoapsis.ortserver.orchestrator | ||
|
|
||
| import io.kotest.core.spec.style.WordSpec | ||
| import io.kotest.matchers.collections.beEmpty | ||
| import io.kotest.matchers.collections.containExactly | ||
| import io.kotest.matchers.should | ||
|
|
||
| import org.eclipse.apoapsis.ortserver.model.JobStatus | ||
|
|
||
| class OrtRunInfoTest : WordSpec({ | ||
| "getNextJobs() with all jobs configured" should { | ||
| val configuredJobs = WorkerScheduleInfo.entries.toSet() | ||
|
|
||
| "return ANALYZER if no job was created yet" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = emptyMap() | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.ANALYZER) | ||
| } | ||
|
|
||
| "return nothing if ANALYZER is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.RUNNING) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return ADVISOR and SCANNER if all previous jobs finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.ADVISOR, WorkerScheduleInfo.SCANNER) | ||
| } | ||
|
|
||
| "return nothing if ADVISOR is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.RUNNING), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return nothing if SCANNER is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.RUNNING) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return EVALUATOR if all previous jobs finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.EVALUATOR) | ||
| } | ||
|
|
||
| "return nothing if EVALUATOR is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.RUNNING) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return REPORTER if all previous jobs finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.REPORTER) | ||
| } | ||
|
|
||
| "return nothing if config worker failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = true, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = emptyMap() | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return REPORTER if ANALYZER failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FAILED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.REPORTER) | ||
| } | ||
|
|
||
| "return REPORTER if ADVISOR failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FAILED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.REPORTER) | ||
| } | ||
|
|
||
| "return REPORTER if SCANNER failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FAILED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.REPORTER) | ||
| } | ||
|
|
||
| "return REPORTER if EVALUATOR failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.FAILED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.REPORTER) | ||
| } | ||
|
|
||
| "return NOTIFIER if REPORTER finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.REPORTER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.NOTIFIER) | ||
| } | ||
|
|
||
| "return NOTIFIER if REPORTER failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.ADVISOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.SCANNER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.REPORTER to WorkerJobInfo(id = 1, status = JobStatus.FAILED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.NOTIFIER) | ||
| } | ||
|
|
||
| "return nothing if all jobs finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = WorkerScheduleInfo.entries.associateWith { | ||
| WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| } | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
| } | ||
|
|
||
| "getNextJobs() with only ANALYZER and EVALUATOR configured" should { | ||
| val configuredJobs = setOf(WorkerScheduleInfo.ANALYZER, WorkerScheduleInfo.EVALUATOR) | ||
|
|
||
| "return ANALYZER if no job was created yet" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = emptyMap() | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.ANALYZER) | ||
| } | ||
|
|
||
| "return nothing if ANALYZER is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.RUNNING) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return nothing if ANALYZER failed" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FAILED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return EVALUATOR if ANALYZER finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should containExactly(WorkerScheduleInfo.EVALUATOR) | ||
| } | ||
|
|
||
| "return nothing if EVALUATOR is still running" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.RUNNING) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
|
|
||
| "return nothing if all jobs finished" { | ||
| val ortRunInfo = OrtRunInfo( | ||
| id = 1, | ||
| configWorkerFailed = false, | ||
| configuredJobs = configuredJobs, | ||
| jobInfos = mapOf( | ||
| WorkerScheduleInfo.ANALYZER to WorkerJobInfo(id = 1, status = JobStatus.FINISHED), | ||
| WorkerScheduleInfo.EVALUATOR to WorkerJobInfo(id = 1, status = JobStatus.FINISHED) | ||
| ) | ||
| ) | ||
|
|
||
| ortRunInfo.getNextJobs() should beEmpty() | ||
| } | ||
| } | ||
| }) |
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && corepack enable | ||
| FROM scratch AS node | ||
| COPY --from=nodebuild $NVM_DIR $NVM_DIR | ||
| # Required for Corepack to dynamically modify binaries of supported package managers. | ||
| RUN sudo chgrp -R 0 /opt/nvm && chmod -R g+rwX /opt/nvm | ||
| && gem install bundler cocoapods:$COCOAPODS_VERSION | ||
| FROM scratch AS ruby | ||
| COPY --from=rubybuild $RBENV_ROOT $RBENV_ROOT | ||
| #------------------------------------------------------------------------ | ||
| # RUST - Build as a separate component | ||
| RUN curl -sSL https://get.haskellstack.org/ | bash -s -- -d $HASKELL_HOME/bin | ||
| FROM scratch AS haskell | ||
| COPY --from=haskellbuild $HASKELL_HOME $HASKELL_HOME | ||
| #------------------------------------------------------------------------ | ||
| # REPO / ANDROID SDK | ||
| && sudo chmod a+x $ANDROID_HOME/cmdline-tools/bin/repo | ||
| FROM scratch AS android | ||
| COPY --from=androidbuild $ANDROID_HOME $ANDROID_HOME | ||
| #------------------------------------------------------------------------ | ||
| # Dart | ||
| && unzip /dart/dart.zip | ||
| FROM scratch AS dart | ||
| COPY --from=dartbuild $DART_SDK $DART_SDK | ||
| #------------------------------------------------------------------------ | ||
| # SBT | ||
| RUN curl -L https://github.com/sbt/sbt/releases/download/v$SBT_VERSION/sbt-$SBT_VERSION.tgz | tar -C /opt -xz | ||
| FROM scratch AS sbt | ||
| COPY --from=sbtbuild $DART_SDK $DART_SDK | ||
| #------------------------------------------------------------------------ | ||
| # SWIFT | ||
| | tar -xz -C $SWIFT_HOME --strip-components=2 | ||
| FROM scratch AS swift | ||
| COPY --from=swiftbuild $SWIFT_HOME $SWIFT_HOME | ||
| #------------------------------------------------------------------------ | ||
| # DOTNET | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like the idea to extract the scheduling logic to a dedicated class, I have some problems with the current implementation:
OrtRunInfois meaningless in this context and rather reminds of a data model class.WorkerScheduleContextis unclear.Orchestratornow creates aWorkerScheduleContext, and with the help of this context, anOrtRunInfo. This is because the latter has its own state derived from the context (this is not really untangling). It would be better ifOrtRunInfowas stateless and only implemented the scheduling strategy. ThegetNextJobs()function could be passed aWorkerScheduleContextinfo object and obtain all required information from there.