Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.rdf for publishing #39

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Update install.rdf for publishing #39

merged 1 commit into from
Jan 27, 2016

Conversation

YoruNoHikage
Copy link
Member

As I was saying on #3, we have to change some info for publishing.

First, ID, I change it to echofox@echofox-team since we do not have any domain/mail.
Second, the name, well it's Echofox, no problem here.
Third, version : 2.6 seems right to me since it's not a major release but not just a fix.

What about the rest ? Any thoughts ?

@ath0mas
Copy link
Member

ath0mas commented Dec 20, 2015

I pushed similar commit to my fork at the same time ^^

We should add commits to this branch and when ready to merge, squash them all into a single one

@YoruNoHikage
Copy link
Member Author

👍

@ath0mas
Copy link
Member

ath0mas commented Dec 20, 2015

echofox@echofox-team or [email protected] for <em:id>?

@YoruNoHikage
Copy link
Member Author

Did you see http://echofox.github.io/ ? So, nope ! xD

@ath0mas
Copy link
Member

ath0mas commented Dec 20, 2015

Alright 😆

@YoruNoHikage
Copy link
Member Author

Ah seems better than the other, just signed a new version ! Let's try it ! (don't need to be OS-specific actually)

echofox-2.6-fx.zip

@ath0mas
Copy link
Member

ath0mas commented Dec 21, 2015

Working fine.
I just figured out how you sign it on AMO without review process :p

@ath0mas
Copy link
Member

ath0mas commented Dec 21, 2015

We changed addon uuid but was it really necessary?
If we go on with it, we should rename Echofon to Echofox everywhere in code, migrate welcome.xul and remove subscribe? but registered app for key when connecting to Twitter to add acount is "Echofon, by naan studio"... + /echofon prefixes, synchronisation system, etc.

@YoruNoHikage
Copy link
Member Author

Same UUID causes validation fail, so we have to change it. For the rest, well, it's just about copyright and stuff we wanted to change before...

@ath0mas
Copy link
Member

ath0mas commented Dec 21, 2015

Ok, so I would suggest not "altering" more original addon: keep Echofon identity everywhere, and set Echofox/Echofox Team only as maintainers

@YoruNoHikage
Copy link
Member Author

I agree but don't you think it would be better to have "Echofon Unofficial" as the name ? Since UUID is different, installing the new version will not replace the old one !

@ath0mas
Copy link
Member

ath0mas commented Dec 21, 2015

Ping @echofox-team/core for name again ^^ see @YoruNoHikage question ahead

@ath0mas ath0mas mentioned this pull request Dec 21, 2015
@ath0mas
Copy link
Member

ath0mas commented Dec 22, 2015

Original name was "Echofon for Firefox" ; so I suggest "Echofon for Firefox - unofficial"

@YoruNoHikage
Copy link
Member Author

A bit long... Just saying :-°

@YoruNoHikage YoruNoHikage mentioned this pull request Jan 12, 2016
@YoruNoHikage YoruNoHikage mentioned this pull request Jan 21, 2016
@YoruNoHikage
Copy link
Member Author

Well, time has flown and Firefox 44 is here, breaking stuff fixed with #36, so we have to make a release, preferably signed. So, we should go for Echofon Unofficial (simpler is better !) and echofon-unofficial@echofox-team as ID.

Can you change this, maybe squash commits and merge ? Do you have time to do this ?

This was referenced Jan 27, 2016
@ath0mas
Copy link
Member

ath0mas commented Jan 27, 2016

I should have time to do it later today

ath0mas added a commit that referenced this pull request Jan 27, 2016
Update install.rdf for publishing
@ath0mas ath0mas merged commit 53017bd into master Jan 27, 2016
@ath0mas
Copy link
Member

ath0mas commented Jan 27, 2016

Squashed commits and merged.
Are we ready to tag version 2.6, sign XPI and create a release on GitHub with all that?

@ath0mas
Copy link
Member

ath0mas commented Jan 27, 2016

... I may have made a mistake, trying signing from AMO pages
I started "submit a new addon", checked "do not list on this website" (step 2), and stopped at step 3
but now, it is listed in "My addons" page, and "delete" button tells me:

Deleting your add-on will permanently remove it from the site and prevent its GUID from being submitted again, even by you.

(not yet deleted)

I may have blacklisted GUID echofon-unofficial@echofox-team ? 😞

Will we be able to sign addon with each of our personal accounts? or should we create a shared account on AMO for @echofox-team/core?

@YoruNoHikage
Copy link
Member Author

We should test and sign before releasing/tagging it on GitHub. I'm on it !

EDIT : oh damn... We should totally create a shared account.

@YoruNoHikage YoruNoHikage deleted the renaming-addon branch January 27, 2016 21:05
@ath0mas
Copy link
Member

ath0mas commented Jan 27, 2016

@YoruNoHikage Chat on gitter?

@YoruNoHikage
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants