Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): fix touch devices - FRONT-4632 #3647

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Sep 25, 2024

fix touch event not working correctly for simple menu

@emeryro
Copy link
Contributor Author

emeryro commented Sep 25, 2024

This was tricky...
The issue is that the mouse hover event is still triggered with touch devices. So in some cases we had the hover and click event triggered together.
I added a bool to make sure that when using a touch device, the hover event is not triggered

Note: if you try switching between touch devices and mouse back and forth, there may be some cases where the hover event is still disabled until you click on the caret.
I choose to ignore this scenario as it does not seem to be a real use case

Copy link

@github-actions github-actions bot temporarily deployed to pull request September 25, 2024 08:24 Inactive
@planctus planctus self-requested a review September 27, 2024 11:15
@planctus planctus merged commit 5747d12 into v4-dev Sep 27, 2024
7 checks passed
@planctus planctus deleted the FRONT-4632-menu-touch branch September 27, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants