Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-download): add preview link - FRONT-4574 #3577

Merged
merged 21 commits into from
Sep 25, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Aug 22, 2024

No description provided.

Copy link

github-actions bot commented Aug 22, 2024

@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 07:33 Inactive
@planctus
Copy link
Contributor

but..do we know what the webtools widget is going to inject here..? Are we sure we need to define the link ourselves or could that be coming from webtools directly? I would imagine them using the download button to build the markup for their widget and add the preview link on request. Maybe you had infomation about this, just asking

@emeryro
Copy link
Contributor Author

emeryro commented Aug 22, 2024

I don't have more information...
All that I know is what we discussed with Sergio in the Teams channel

@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 12:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 13:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 07:47 Inactive
@planctus
Copy link
Contributor

I've asked to gather information about this request, the response is that the button will be injected by webtools, they also have the option to show it before or after the download button, but basically we don't need to do anything as long as we don't receive specific requests by webtools. So we can close this pull request, we won't demo the "preview" button at all.

@emeryro
Copy link
Contributor Author

emeryro commented Aug 27, 2024

I'm not fully sure... If Webtools add the button, that's fine for me, but in the PR I had to create a container for the buttons, to be able to place them correctly.
I don't know if that would still be needed

@planctus
Copy link
Contributor

i guess that they will wrap by themselves the two buttons as they do in their demo, if they will need anything from us they will request it

@emeryro emeryro closed this Aug 28, 2024
@planctus planctus reopened this Sep 4, 2024
@planctus
Copy link
Contributor

planctus commented Sep 17, 2024

Mmh..but how are we "testing" the webtools markup and css that will be injected like this? We added css on our side to handle a second link, but we will get styles that will potentially conflict with those, that was the idea, to set up a demo using the webtools markup and css so that we could reliably expect the widget to look ok in our component.
About "our" styles, it seems we need to handle the small viewports, this is what happens currently:
image

@emeryro
Copy link
Contributor Author

emeryro commented Sep 18, 2024

I would say that it is up to Webtools to ensure that their markup and css are displayed correctly. We offer a wrapper, and provide an example with a link. I don't want to add specific Webtools css in our repo, as we would have to maintain it.
I pushed an update to add the webtools data attribute hen needed (to check if it is possible), and to remove the spacing from our css as it will be handled on their side

@github-actions github-actions bot temporarily deployed to pull request September 18, 2024 06:30 Inactive
@planctus
Copy link
Contributor

it's from the beginning of this tale that we've been warned about the fact that the styles coming from webtools will not take care of the ECL file download component. This whole idea is based on the fact that we might have conflicting styles or issues, in any case, once webtools will start injecting their markup and css.
This work here, other than for adding a wrapper, was meant to test the component with the webtools markup and css, i don't like the idea either of having webtools injecting anything in a component or ours, but that is the case, so here we are trying to ensure that will not result in a completely broken functionality once it will be enabled.

@emeryro
Copy link
Contributor Author

emeryro commented Sep 18, 2024

But they are using our markup and css (with a prefix). The only thing added on their side is the spacing after the link; that's why I handled it in the story and not in the css. The rest of the css is the same.
image
image

@planctus
Copy link
Contributor

I remember Vlad expecting some vertical spacing in this case:
image

@github-actions github-actions bot temporarily deployed to pull request September 18, 2024 13:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 06:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 07:05 Inactive
@planctus planctus self-requested a review September 24, 2024 07:27
@github-actions github-actions bot temporarily deployed to pull request September 25, 2024 08:39 Inactive
@emeryro emeryro merged commit 7deb626 into v4-dev Sep 25, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4574-file-preview branch September 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants