-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file-download): add preview link - FRONT-4574 #3577
Conversation
but..do we know what the webtools widget is going to inject here..? Are we sure we need to define the link ourselves or could that be coming from webtools directly? I would imagine them using the download button to build the markup for their widget and add the preview link on request. Maybe you had infomation about this, just asking |
I don't have more information... |
I've asked to gather information about this request, the response is that the button will be injected by webtools, they also have the option to show it before or after the download button, but basically we don't need to do anything as long as we don't receive specific requests by webtools. So we can close this pull request, we won't demo the "preview" button at all. |
I'm not fully sure... If Webtools add the button, that's fine for me, but in the PR I had to create a container for the buttons, to be able to place them correctly. |
i guess that they will wrap by themselves the two buttons as they do in their demo, if they will need anything from us they will request it |
I would say that it is up to Webtools to ensure that their markup and css are displayed correctly. We offer a wrapper, and provide an example with a link. I don't want to add specific Webtools css in our repo, as we would have to maintain it. |
it's from the beginning of this tale that we've been warned about the fact that the styles coming from webtools will not take care of the ECL file download component. This whole idea is based on the fact that we might have conflicting styles or issues, in any case, once webtools will start injecting their markup and css. |
No description provided.