Add interaction elements and attributes to audioObject #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be booleans, and have default values (where they are not required).
Not allowing these to be None removes an extra case to handle, and does not restrict the possible range of ADM content that can be represented. These should also be validated.
Felix master
|
Thanks, I'll take a look soon. The things that stand out immediately are that the parsing looks quite different from the original code, and the testing is not complete; it should check that the parsed values match the values in the XML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this has been discussed already some time ago and I'm not quite sure what the conclusion was (if there was one). It would be, however, great to add interaction elements and attributes to the main repo!