-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rc07 #29
Feat/rc07 #29
Conversation
Signed-off-by: sajanrajdev <[email protected]>
Signed-off-by: sajanrajdev <[email protected]>
Signed-off-by: sajanrajdev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed up to the following commit
changes looks good on the interfaces matching the latest ebtc architecture release, adds also lido token, but it is not used anywhere? seeing the interface seems more its the interface for steth
than ldo
, worth matching the naming?
adds an approx helpers to allow tests accommodate to the known issue in their token, ref ✅
Thank you very much for your review @petrovska-petro. The reason for adding stETH's Interface is for when the mainnet contracts are wired. Perhaps we should make the libraries use the interfaces for the collateral and price feed be chosen dynamically based on the chain. I attempted this but, for some reason, the script breaks whenever I try to call Comments were addressed, lint was fixed and all tests are passing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed all suggestions were tackle and tests passed succesfully ✅
it also included in the gov scripts 2 missing methods re batching the collateral and redemp fee floor related to source ✅
batch_collateral_feed_source_and_redemption_fee_floor
All tests are passing:
TODO: Add scripts for the new functions and make sure that non of the previous scripts broke.