Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rc07 #29

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Feat/rc07 #29

merged 20 commits into from
Mar 8, 2024

Conversation

sajanrajdev
Copy link
Collaborator

@sajanrajdev sajanrajdev commented Feb 26, 2024

  • Introduces Mainnet contracts RC0.7
  • Introduces Sepolia version of RC0.7
  • Adapts tests to RC0.7 changes:
    • Governance around new functions
    • Introduces Timelock batching for atomic coll feed source with redemption fee floor change
    • Adds and adapts tests to all of the above
    • Adapts CDP Ops tests for the fixed collateral (mimics Lido's stETH, which means that it also replicates its rounding issue, noted and workaround implemented)
    • Updates all Interfaces
    • Deployed a testnet, working, mock fallback Oracle and adapted test to use it (with its on-chain checks passing)
    • Lint on Solidity and Python

All tests are passing:
image

TODO: Add scripts for the new functions and make sure that non of the previous scripts broke.

Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-29 at 21 32 19

reviewed up to the following commit

changes looks good on the interfaces matching the latest ebtc architecture release, adds also lido token, but it is not used anywhere? seeing the interface seems more its the interface for steth than ldo, worth matching the naming?

adds an approx helpers to allow tests accommodate to the known issue in their token, ref

great_ape_safe/ape_api/ebtc.py Outdated Show resolved Hide resolved
great_ape_safe/ape_api/ebtc.py Outdated Show resolved Hide resolved
great_ape_safe/ape_api/ebtc.py Outdated Show resolved Hide resolved
great_ape_safe/ape_api/ebtc.py Show resolved Hide resolved
great_ape_safe/ape_api/ebtc.py Outdated Show resolved Hide resolved
great_ape_safe/ape_api/ebtc.py Show resolved Hide resolved
@sajanrajdev
Copy link
Collaborator Author

Thank you very much for your review @petrovska-petro. The reason for adding stETH's Interface is for when the mainnet contracts are wired. Perhaps we should make the libraries use the interfaces for the collateral and price feed be chosen dynamically based on the chain. I attempted this but, for some reason, the script breaks whenever I try to call chain.id. This is why I haven't used the r instance of the registry. Could you check if it works on your side? I have been digging for a while with no luck.

Comments were addressed, lint was fixed and all tests are passing:
image
image

@sajanrajdev sajanrajdev marked this pull request as ready for review March 5, 2024 23:46
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed all suggestions were tackle and tests passed succesfully ✅

it also included in the gov scripts 2 missing methods re batching the collateral and redemp fee floor related to source

batch_collateral_feed_source_and_redemption_fee_floor

@sajanrajdev sajanrajdev merged commit f076690 into main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants