-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monster archive #142
base: master
Are you sure you want to change the base?
Monster archive #142
Conversation
Add quasar/cli to dev dependencies, force clean install
thanks for the PR! I'll check it out when I have time. Before I get some hands on time with this branch, couple things off the top of my head that are blockers for merge:
|
Thanks for your feedback.
|
indexedDB is available on all relevant browsers so that shouldn't be a problem. thinking about this a bit, I think we should actually treat these as "files" and let users specify a unique name for each of their monsters (easier to track that vs uuid + non unique monster name). As for what the UX of that would look like, I'm thinking there are basically two states we could be in:
Implementing the above doesn't require any changes to the monster store, but will require some changes to the actions that happen on load and on reset (which is fine). If none of this makes sense let me know; I can find some time to implement directly in this branch or can set up a branch in this repo for us to collab on. Leave the data models for the other areas alone for now, once we have indexedDB from this feature I'll work on moving the other data over as needed. spells and templates should live in there for sure, current monster probably lives in localStorage still. but all of that is out of scope for this PR |
Thanks for the write-up of a concept. It turns out to be quite similar to my thoughts on how the storage should work. I was under the impression that we could just switch the storage backend to IndexedBD with pinia. Having looked at it I now understand why you proposed Dexie. I will work on implementing IndexedDB for the archive using uuids for the entries. And fix the confirmation dialogs as well 👍 |
awesome, thanks! We could switch the entire backend to indexedDB with a pinia plugin, but i'd prefer to do that gradually :) |
I was using the builder for some of my custom One-Shots and soon struggled to organize my monsters. I work on different monsters on and off, so exporting and reimporting became a bit tedious.
So, I took some time over the weekend and added a monster archive. It allows to save and manage multiple monsters within the app itself.
This addition might also be helpful for #140.
Functionality:
Limitations:
Changing the name creates a new entry in the archive. Other solutions would require a unique identifier per monster (e.g. on reset).
Might be helpful to download many markups quickly instead of loading each monster into the builder.
Technical info:
Testing:
I did some manual testing so far but haven't used it "productively".
Happy to hear any feedback on the idea and the implementation :)