Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ember Model to work with Ember 3.2 #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richgt
Copy link

@richgt richgt commented Feb 27, 2019

These changes are copied from CondeNast's fork at https://github.com/CondeNast-Copilot/ember-model, specifically from commit
CondeNast-Copilot@9309a9c.

  • Bump addon to 3.0 and make compatible with 3.2
  • Remove leaky variable declarations in model#load method
  • Don't load embedded polymorphic relationships in method#load (no necessary and causes collisions)
  • Fix tests and travis setup

These changes are copied from CondeNast's fork at https://github.com/CondeNast-Copilot/ember-model, specifically from commit
CondeNast-Copilot@9309a9c.

- Bump addon to 3.0 and make compatible with 3.2
- Remove leaky variable declarations in model#load method
- Don't load embedded polymorphic relationships in method#load (no necessary and causes collisions)
- Fix tests and travis setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant