Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base type once Signal is float in Fibex #818

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Dalilaroussi
Copy link
Contributor

@ebroecker , based on the specification , once SIG_VALTYPE is 1 or 2 it's float , this need to be fixed in fibex
image

Copy link

Pull Request Test Coverage Report for Build 11236996599

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 24 (4.17%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 53.344%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/canmatrix/formats/fibex.py 1 24 4.17%
Files with Coverage Reduction New Missed Lines %
src/canmatrix/formats/fibex.py 2 6.57%
Totals Coverage Status
Change from base Build 10935562972: -0.03%
Covered Lines: 4459
Relevant Lines: 8359

💛 - Coveralls

@ebroecker ebroecker merged commit d6bb599 into ebroecker:development Oct 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants