rename findNotUsedBits in get_frame_layout #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let get_frame_layout create array for each bit containing signals using this bit fix createDummySignals to use get_frame_layout rename createDummySignals to create_dummy_signals
Codecov Report
@@ Coverage Diff @@
## development #254 +/- ##
===============================================
- Coverage 30.8% 30.73% -0.08%
===============================================
Files 30 30
Lines 6499 6495 -4
Branches 1622 1620 -2
===============================================
- Hits 2002 1996 -6
- Misses 4304 4305 +1
- Partials 193 194 +1
Continue to review full report at Codecov.
|
|
I think, I have changed everything as you proposed. Thanks in advance |
altendky
requested changes
Nov 28, 2018
Co-Authored-By: ebroecker <[email protected]>
Co-Authored-By: ebroecker <[email protected]>
Co-Authored-By: ebroecker <[email protected]>
Co-Authored-By: ebroecker <[email protected]>
|
@altendky Thanks again |
altendky
changed the title
* correct big_bits for big_endian
altendky
requested changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should once fix #227
let get_frame_layout create array for each bit containing signals using this bit
fix createDummySignals to use get_frame_layout
rename createDummySignals to create_dummy_signals