[pull] main from ManimCommunity:main #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* first rework * use rotvec and updated transpose rot mat * shortcut for about z_axis * rework get_unit_normal * rewrite center_of_mass * rewrite find_intersection * shoelace using trapz * use external quaternion package * Correct error message Co-authored-by: Kiran-Raj-Dev <[email protected]> * correct the tests No major change, just tiny differences due to floating point error * new test * Update test_space_ops.py * Revert "use external quaternion package" This reverts commit 1fc318c. * Update space_ops.py * updated tests * updated tests and error message * Technically called segments Co-authored-by: Darylgolden <[email protected]> * minor changes in wording regarding intersection (lines vs line segments) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Kiran-Raj-Dev <[email protected]> Co-authored-by: Darylgolden <[email protected]> Co-authored-by: Benjamin Hackl <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )