Avoid panic if creating volume from source fails

If a driver advertises CREATE_DELETE_SNAPSHOT but fails to obey the part of the spec about allowing CreateVolume from a snapshot (such as during an incremental development of a driver), the testsuite was panicking on a nil dereference instead of diagnosing that an unexpected error was returned. Fixes: kubernetes-csi#569 Signed-off-by: Eric Blake <[email protected]>
ebblake · Jan 20, 2025 · 66041d1 · 66041d1
1 parent 3ad33cb
commit 66041d1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/sanity/controller.go b/pkg/sanity/controller.go
@@ -676,8 +676,9 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
 				},
 			}
 			vol, err := r.CreateVolume(context.Background(), vol2Req)
-			Expect(vol.GetVolume().ContentSource).NotTo(BeNil())
 			Expect(err).NotTo(HaveOccurred())
+			Expect(vol).NotTo(BeNil())
+			Expect(vol.GetVolume().ContentSource).NotTo(BeNil())
 		})
 
 		It("should fail when the volume source snapshot is not found", func() {