Added support for recurring events on Android and iOS #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added new API method to delete recurring or normal events with specified span (needs to be tagged with @SInCE in JsDoc) Info: The new API endpoint needs to be added to the example app
ebarooni
requested changes
Sep 27, 2024
| @@ -381,6 +383,8 @@ export interface CapacitorCalendarPlugin { | |||
|
|
|||
| /** | |||
| * Deletes events from the calendar given their IDs. | |||
| * If the event is recurring it will automatically delete this and future events. | |||
There was a problem hiding this comment.
This might lead to unwanted behaviors. Could you add an optional span property for being able to choose between this or all future events to be deleted?
There was a problem hiding this comment.
The problem kind of is that this only needs to be supplied for recurring events.
It would be possible to add an EventSpan array but this would have a lot of overhead for the caller of the function.
Maybe we could think of a different approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Merge Request adds support for recurring events on the following platforms:
Additions
deleteEventById(JsDoc needs to be updated with@since)Important Info
Contributions
Closes #99