lintr

easystats · Jan 31, 2024 · 07c2a33 · 07c2a33
1 parent 9746fd1
commit 07c2a33
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/R/geom_from_list.R b/R/geom_from_list.R
@@ -189,7 +189,7 @@ geom_from_list <- function(x, ...) {
   }
 
   # Default for violin
-  if (x$geom == "violin") {
+  if (x$geom == "violin") { # nolint
     stat <- "ydensity"
     position <- "dodge"
   } else if (x$geom == "boxplot") {

diff --git a/R/plot.check_model.R b/R/plot.check_model.R
@@ -209,9 +209,9 @@ plot.see_check_model <- function(x,
     pw <- plots(p, n_columns = n_columns)
     .safe_print_plots(pw, ...)
     invisible(pw)
-  } else {
-    return(p)
   }
+
+  p
 }
 
 

diff --git a/R/plot.check_normality.R b/R/plot.check_normality.R
@@ -68,7 +68,7 @@ plot.see_check_normality <- function(x,
       alpha_level = alpha
     )
   } else {
-    if (type == "qq") {
+    if (type == "qq") { # nolint
       model_info <- attributes(x)$model_info
       if (inherits(model, c("lme", "lmerMod", "merMod", "glmmTMB", "afex_aov", "BFBayesFactor"))) {
         res_ <- suppressMessages(sort(stats::residuals(model), na.last = NA))

diff --git a/R/plot.check_outliers.R b/R/plot.check_outliers.R
@@ -41,9 +41,9 @@ plot.see_check_outliers <- function(x,
                                     ...) {
   type <- match.arg(type)
   influential_obs <- attributes(x)$influential_obs
-  methods <- attr(x, "methods", exact = TRUE)
+  outlier_methods <- attr(x, "methods", exact = TRUE)
 
-  if (type == "dots" && !is.null(influential_obs) && (is.null(methods) || length(methods) == 1)) {
+  if (type == "dots" && !is.null(influential_obs) && (is.null(outlier_methods) || length(outlier_methods) == 1)) {
     .plot_diag_outliers_new(
       influential_obs,
       show_labels = show_labels,
@@ -52,12 +52,10 @@ plot.see_check_outliers <- function(x,
       dot_alpha_level = dot_alpha,
       colors = colors
     )
+  } else if (length(outlier_methods) == 1) {
+    .plot_diag_outliers(x, show_labels = show_labels, size_text = size_text, rescale_distance = rescale_distance)
   } else {
-    if (length(methods == 1)) {
-      .plot_diag_outliers(x, show_labels = show_labels, size_text = size_text, rescale_distance = rescale_distance)
-    } else {
-      .plot_outliers_multimethod(x, rescale_distance)
-    }
+    .plot_outliers_multimethod(x, rescale_distance)
   }
 }