Remove pp_check() alias
#706
Conversation
R/check_predictions.R
Outdated
| @@ -161,10 +161,37 @@ check_predictions.stanreg <- function(object, | |||
| ) | |||
|
|
|||
| if (inherits(object, "brmsfit")) { | |||
| out <- bayesplot::pp_check(object, type = type, ndraws = iterations, ...) | |||
| out <- as.data.frame(bayesplot::pp_check(object, type = type, ndraws = iterations, ...)) | |||
There was a problem hiding this comment.
do we even need to call bayesplot? Couldn't we directly compute predictions like in #202 (comment)
though it might be less efficient
There was a problem hiding this comment.
Not sure how we can get dot-plots for discrete/integer outcomes?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
- Coverage 60.22% 59.83% -0.39%
==========================================
Files 86 86
Lines 6283 6322 +39
==========================================
- Hits 3784 3783 -1
- Misses 2499 2539 +40 ☔ View full report in Codecov by Sentry. |
|
Why do we want to remove the aliases? I thought we had resolved the conflicts with pp_check(), and think there is value in exporting methods for that generic? |
|
We don't want to remove |
Fixes #477