Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursion in logLik.plm() that slows down computations: #623

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Recursion in logLik.plm() that slows down computations: #623

merged 6 commits into from
Sep 27, 2023

Conversation

strengejacke
Copy link
Member

Fixes #622

IndrajeetPatil
IndrajeetPatil requested changes Sep 27, 2023
View reviewed changes
R/logLik.R Outdated Show resolved Hide resolved
tests/testthat/test-logLik.R Outdated Show resolved Hide resolved
tests/testthat/test-logLik.R Show resolved Hide resolved
tests/testthat/test-logLik.R Outdated Show resolved Hide resolved
strengejacke and others added 4 commits September 27, 2023 14:06
@strengejacke @IndrajeetPatil
Update R/logLik.R
6325013 
Co-authored-by: Indrajeet Patil <[email protected]>
@strengejacke @IndrajeetPatil
Update tests/testthat/test-logLik.R
fd61006 
Co-authored-by: Indrajeet Patil <[email protected]>
@strengejacke @IndrajeetPatil
Update tests/testthat/test-logLik.R
d15551b 
Co-authored-by: Indrajeet Patil <[email protected]>
@strengejacke @IndrajeetPatil
Update tests/testthat/test-logLik.R
201f3c3 
Co-authored-by: Indrajeet Patil <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #623 (120d6bf) into main (462e8ae) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 120d6bf differs from pull request most recent head 659ee32. Consider uploading reports for the commit 659ee32 to get more accurate results

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files          84       84           
  Lines        5804     5804           
=======================================
  Hits         3010     3010           
  Misses       2794     2794
Files Coverage Δ
R/logLik.R 31.70% <0.00%> (ø)

@strengejacke strengejacke merged commit ddaebc7 into main Sep 27, 2023
25 checks passed
@strengejacke strengejacke deleted the strengejacke/issue622 branch September 27, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursion in logLik.plm() that slows down computations:
2 participants
@strengejacke @IndrajeetPatil