Ignore unmodified files when using --new-pr or --update_pr
#4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When including an unmodified EasyConfig with `--new-pr` an error is shown that a commit message is required because this EC is modified which is not the case. Adjust the `copy_*` functions to ignore any unmodified file. This especially ommits them in the `file_info` struct returned that is then used to determine commit message/title etc. Fixes easybuilders#4751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including an unmodified EasyConfig with
--new-pran error is shown that a commit message is required because this EC is modified which is not the case.Adjust the
copy_*functions to ignore any unmodified file. This especially omits them in thefile_infostruct returned that is then used to determine commit message/title etc.Fixes #4751
Note: While working on this I noticed that new EasyConfigs that are dependencies of added EasyConfigs are ignored in the commit message. I propose to populate
file_infoinstead of thedep_infoateasybuild-framework/easybuild/tools/github.py
Line 1071 in b37f707
This would also fix the possibly incomplete debug log message
Staging all <n> new/modified easyconfigsthat doesn't account for those ECs.