-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization context added #234
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess for the moment we will just manage these organisation properties through postman. It's fine for the testing phase but at the end the client will want to manage that by himself easily. Will it be possible ?
Yes I believe it will be possible for the Admins to change these values. My idea was to add this functionality in the single Key page. This feature won't be available for V1, but definitely a possibility for the future. |
"keyNumber": "https://vocab.egm.io/keyNumber", | ||
"name": "https://schema.org/name", | ||
"opensGate": "https://vocab.egm.io/opensGate", | ||
"organization": "https://vocab.egm.io/organization", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a type, not an attribute? if so, it should be Organization.
and this one is better suited: https://schema.org/Organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, is it a group or an organization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both I suppose. They used the terminology "Organism". I can swap to Organization entities. Would be better to have them separate anyways for managing them (adding, deleting, updating)
"type": "Property", | ||
"value": "Fire Department" | ||
} | ||
"isAvailableForOrganization": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is a multi-instance attribute, you have to use datasetId
to distinguish each instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood
"organization": { | ||
"type": "Property", | ||
"value": "Agglomération Provence Verte" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if groups and groups membership are managed in KC, you can't duplicate them here (actually, Stellio already manages this info)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this for SMBT though, for "Conch" & "Autre". That way can verify who has what access on the front via Admin account. For example, Admin user is approving an Authorization which has a relationship of "givenTo" which is a UserProfile id. That way we can then download the UserProfile and check which keys they have access to. Is there another way to achieve this?
"type": "Property", | ||
"value": "Agglomération Provence Verte" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would instead see this as a relationship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Will update with new Organization type
Converting to draft until further decisions have been made on the data flow of the project. Things should be more clear after the meeting with client on 9/10/2024. |
Added organization which will be used in UserProfile entity, will mimic the group assigned to the user in Keycloak. Also added isAvailableForOrganization which replaces category. isAvailableForOrganization will be on the Key entity to dictate which organizations have access at which keys.