Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates in ReferenceElements #292

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

vickysharma0812
Copy link
Member

@vickysharma0812 vickysharma0812 commented Mar 9, 2024

Updates in the Reference Element.

  • Adding GetEdgeConnectivity
  • Adding GetFaceConnectivity
  • Adding routines for reference coordinates

Generated summary (powered by Graphite)

TL;DR

Changes were made to the ReferencePrism_Method.F90 file in the Geometry module to modify the GetEdgeConnectivity_Prism and GetFaceConnectivity_Prism subroutines to be PURE modules. The subroutines now return the number of edges and faces in the element, respectively.

What changed

  • Modified GetEdgeConnectivity_Prism and GetFaceConnectivity_Prism subroutines to be PURE modules.
  • Added functions for retrieving edge and face connectivity information for a pyramid element.
  • Updated module procedures for initiating and referencing a prism element.

How to test

  1. Compile the updated ReferencePrism_Method.F90 file.
  2. Run test cases that utilize the GetEdgeConnectivity_Prism and GetFaceConnectivity_Prism subroutines.
  3. Verify that the subroutines return the correct number of edges and faces for a prism element.

Why make this change

  • To improve code readability and maintainability by making the subroutines PURE modules.
  • To enhance the functionality of the module by adding functions for edge and face connectivity information.
  • To align the module procedures with naming conventions and improve consistency within the codebase.

Copy link
Member Author

vickysharma0812 commented Mar 9, 2024

Merge activity

@vickysharma0812 vickysharma0812 force-pushed the 03-09-Updates_in_reference_prism branch from 7ad9f08 to 71e52ca Compare March 9, 2024 07:03
@vickysharma0812 vickysharma0812 changed the base branch from 03-09-Updates_in_reference_prism to dev March 9, 2024 07:07
@vickysharma0812 vickysharma0812 force-pushed the 03-09-Minor_updates_in_ReferenceElements branch from eb08fc7 to 18558aa Compare March 9, 2024 07:09
@vickysharma0812 vickysharma0812 merged commit f08abfd into dev Mar 9, 2024
1 check passed
@vickysharma0812 vickysharma0812 deleted the 03-09-Minor_updates_in_ReferenceElements branch March 21, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants