Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug in ReferenceQuad #281

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fixing bug in ReferenceQuad #281

merged 2 commits into from
Jan 30, 2024

Commits on Jan 30, 2024

  1. Fixing bug in ReferenceQuadrangle_Method 

    - Initiate method has been fixed
    @vickysharma0812
    vickysharma0812 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    16a3683 View commit details
    Browse the repository at this point in the history

  2. Fixing bug in ReferenceQuadrangle_Method (#280) 

    - Initiate method has been fixed

---

<details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary>

> ## TL;DR
> This pull request modifies the `[email protected]` file to fix an issue with the `InterpolationPoint_Quadrangle` function call. The `xij` parameter now correctly uses the entire `refelem%xij` array instead of a subset.
> 
> ## What changed
> In the `[email protected]` file, the `InterpolationPoint_Quadrangle` function call was modified. Previously, it was using a subset of the `refelem%xij` array (`refelem%xij(1:3, 1:4)`). Now, it uses the entire array (`refelem%xij`).
> 
> ```diff
> -    & xij=refelem%xij(1:3, 1:4), &
> +    & xij=refelem%xij, &
> ```
> 
> ## How to test
> To test this change, you can run the existing unit tests for the `[email protected]` file. If the tests pass, it indicates that the change is working as expected. If there are no existing tests, consider adding some to verify the correct behavior of the `InterpolationPoint_Quadrangle` function call.
> 
> ## Why make this change
> This change is necessary because the previous code was not using the entire `refelem%xij` array, which could lead to incorrect results. By using the entire array, we ensure that the `InterpolationPoint_Quadrangle` function has all the necessary data to perform its calculations correctly.
</details>
    @vickysharma0812
    vickysharma0812 authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ecb49a6 View commit details
    Browse the repository at this point in the history