Remove egctl auto change protocol #1162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now,
egctl
automatically updatehttp
protocol tohttps
protocol is response status code is 400 and response body containsHTTPS
.This strategy can cause some additional problem. As described in #1161 , if user create/update httpserver with yamls, then
easegress-server
may return status code of 400 and a response body withhttps
in it (for example, some message about tls config). In this case,egctl
will try to update protocol fromhttp
tohttps
. Then will cause error ofhttp: server gave HTTP response to HTTPS client
.So, this pr update this protocol change strategy. https://github.com/golang/go/blob/master/src/net/http/server.go#L1922-L1929 based on golang net/http implementation.