-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misuse of omitempty in jsonschema #1136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx7xxxx
changed the title
@xxx7xxxx Fix misuse of omitempty in jsonschema
Fix misuse of omitempty in jsonschema
Nov 13, 2023
suchen-sci
previously approved these changes
Nov 15, 2023
@xxx7xxxx looks good to me, just two little typo. |
Co-authored-by: su chen <[email protected]>
Co-authored-by: su chen <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 81.23% 81.23% -0.01%
==========================================
Files 148 148
Lines 16623 16618 -5
==========================================
- Hits 13504 13499 -5
+ Misses 2480 2479 -1
- Partials 639 640 +1 ☔ View full report in Codecov by Sentry. |
suchen-sci
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the massive misuse of
omitempty
in #884 . Now the fields without specifyingomitempty
would be required by default.As for the required misuse, I don't think there is a simple and brute solution like
emitempty
. Sincerequired
needs to change the type to its pointer type, which would cause a lot of huge changes. Another way is to change the vendor to do it, which will bring more complexity. I suggest letting it be and changing it in the next development step by step.