Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #364

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update README.md #364

merged 3 commits into from
Oct 6, 2023

Conversation

JKinsler
Copy link
Collaborator

Fixed portfolio link in my README.md

@eculler eculler requested review from a team, advythr and NobodyLivesHere and removed request for a team September 26, 2023 15:43
advythr
advythr approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@advythr advythr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Johanna,

I really like your portfolio website and especially that it has two columns where one scrolls while the other one stays fixed. My only suggestion is to make the project links into hyperlinks instead of plain text links.

NobodyLivesHere
NobodyLivesHere approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@NobodyLivesHere NobodyLivesHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything that should be is there. Might be helpful to include a few short text descriptions next to the data tables explaining the figures as the way python spits them out can sometimes be hard to decipher.

@eculler eculler merged commit 8a8329e into main Oct 6, 2023
@eculler eculler deleted the JKinsler-3 branch October 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyLivesHere NobodyLivesHere NobodyLivesHere approved these changes

@advythr advythr advythr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JKinsler @advythr @NobodyLivesHere @eculler