Icechunk learns how to delete tags. #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
approved these changes
Jan 24, 2025
| @@ -195,6 +197,9 @@ async def test_icechunk_can_read_old_repo() -> None: | |||
| 1: | |||
| ] | |||
|
|
|||
| with pytest.raises(ValueError, match="ref not found"): | |||
There was a problem hiding this comment.
Sounds we make a new subclass of IcechunkError for this while working on this?
There was a problem hiding this comment.
I think our whole error hierarchy needs a revamp. Let me delay this until we do that rfactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See design document