Add Datanoise PicoADK v2 (RP2350). #2413
Conversation
|
@earlephilhower How can I add variants of the v2 board? E.g. there is a version without PSRAM and a version with 8MB PSRAM. |
|
If it's just PSRAM then I might special-case |
Is BuildPSRAM() something you need to implement or is there something I could do? The V2 is coming out in the next couple of weeks. Let me know if you want one! |
|
arduino-pico/tools/makeboards.py Line 51 in 902f709 |
|
@earlephilhower Ok, done! |
|
The PSRAM_CS is fixed at GPIO0 when the PSRAM is used. What is the best place to put it? |
|
The CS define is normally set in the variant file. |
|
Also, I think the psram function should be called in the next if block , not where you've got it now. The current code will miss the flash filesystem size completely, I think. |
Done. |
tools/makeboards.py
Outdated
| @@ -298,7 +298,10 @@ def MakeBoard(name, chip, vendor_name, product_name, vid, pid, pwr, boarddefine, | |||
| BuildFlashMenu(name, chip, 8*1024*1024, [0, 7*1024*1024, 4*1024*1024, 2*1024*1024]) | |||
| BuildFlashMenu(name, chip, 16*1024*1024, [0, 15*1024*1024, 14*1024*1024, 12*1024*1024, 8*1024*1024, 4*1024*1024, 2*1024*1024]) | |||
| elif name == "datanoisetv_picoadk_v2": | |||
| BuildPSRAM(name) | |||
| BuildPSRAM(name) | |||
| BuildPSRAMCS(name) | |||
There was a problem hiding this comment.
BukldPSRAMCS, BuildPSRAMFREQ, and BuildFreq aren't needed here. You have a hard-wired board and know the CS pin (which should be a #define PSRAM_CS xxx in variants/datanoisetv_v2/pins_arduino.h). There's no reason to have these as a menu. Only the first PSRAM size via buildpsram is needed here. See the challenger_2350_bconnect or other RP2350 board w/PSRAM for more info...
There was a problem hiding this comment.
So I should just leave BuildPSRAM? Could you check the latest commit and maybe make necessary changes if possible? I am currently working on some example code.
There was a problem hiding this comment.
If your board always has PSRAM then there's no need for these menus. Define the proper pin/clock/CS in the variant.h like in the other 2350+PSRAM boards and it will "just work."
If there are 2 boards, 1 with and 1 without, then only the BuildPSRAM menu makes sense to have because everything else if defined by the PCB.
BuildFreq is called 3 lines below, so the instance here is duplicate That's not legal and I'm not sure what the IDE will do in that case. Best case you end up with some weird dup's menu items.
|
I have implemented the changes. Could you check? |
|
The boards file is still not matching the generated output of makeboards, so something is still not quite up to date in the commits to the PR... |
I aplologise. I had some lack of sleep recently. Just pulled from master, merged and reworked it. |
tools/makeboards.py
Outdated
| @@ -326,6 +326,8 @@ def MakeBoard(name, chip, vendor_name, product_name, vid, pid, pwr, boarddefine, | |||
| BuildPSRAMCS(name) | |||
| BuildPSRAM(name) | |||
| BuildPSRAMFreq(name) | |||
| elif name == "datanoisetv_picoadk_v2": | |||
| BuildFreq(name, 400) | |||
There was a problem hiding this comment.
Sorry, but again you still have 2 frequency menus being generated. Line 323 and line 330.
This reverts commit e92ffd5. which accidenally removed a file.
|
|
Assuming the close was a mistake, re-opening and will merge after CI |
No description provided.