-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat issue view #23
base: master
Are you sure you want to change the base?
Feat issue view #23
Conversation
Sorry for the delay, I'm migrating to a new laptop and I just reconfigured my Ruby setup. You seem to have more than one change in the PR. You're also adding risk grouping support, but the feature doesn't look finished. When I group risks by probability or impact, the key is displayed instead of the label. Can you move this feature to another PR to facilitate the review? For the main functionality (i.e., the issue view), you've also changed the risk form, but select are now truncated. Would it be possible to avoid touching this form? Also, to facilitate future maintenance of the functionality, I think it would have been easier to avoid using a popup and simply redirect the user to the risk creation form with a query parameter Thanks! |
Sorry for the risk_query.rb, i've forgotten it (i have some features on this plugin). To use this form in a "Add Risk" popup on Issue form i need to change like that... and other functions use popup on issue form (like create new version). I'll check tomorrow "select are now truncated." To speak other feat., i make patch to redmine project to use diff Journal (who's actually in error on risk's description for example). |
Hello I can't reproduce the bug on risk form. No truncated element. Can you explain or show on a picture ? |
OK, i see.... I'm using PurpleMine theme and i don't have this problem... |
Hello, We are migrating our REDMINE to version 5 and I would like to move forward on our various developments on the plugins |
Manage risks in issue's view :