Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config_example.yaml work #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

make config_example.yaml work #52

wants to merge 3 commits into from

Conversation

axapta
Copy link
Contributor

@axapta axapta commented Apr 16, 2017

No description provided.

Copy link
Member

@janLo janLo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally ok, just a few things that should be changed before merge.

The data directory is mounted to /data within the container. So make
sure that your database is within that path.

$ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data <image-name>
$ git clone https://github.com/janLo/meet-and-eat-registration-system.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would seperate this, as it has nothing to do with the actual docker deployment

$ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data <image-name>
$ git clone https://github.com/janLo/meet-and-eat-registration-system.git
$ cd meet-and-eat-registration-system
$ docker build . -t <image-name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give here the alternatives:

  • Build the image yourself.
  • Pull the image from the docker hub.

$ git clone https://github.com/janLo/meet-and-eat-registration-system.git
$ cd meet-and-eat-registration-system
$ docker build . -t <image-name>
$ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data -p 8080:8080 <image-name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change -p 8080:8080 to [<hostaddress>]:<hostport>:8080, as the first one is the special case where you publish the port on 8080 on any address of your host system. This is not what you want in production.


Now try to access the Websites:

localhost:8080/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you really want to give this, then exchange localhost:8080 and 127.0.0.1:8080 with <hostaddress>:<hostport>:8080 and either give a full list of all accessible endpoints or remove /admin/login, as /admin redirects to that.

@@ -50,7 +50,8 @@ ADMIN_PASSWORD: "test"
# Format: "yyyy-mm-dd HH:MM"
REGISTER_END: "2020-05-01 22:30"
MAX_TEAMS: 51
VOLUME: 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have to change this in the example but ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants