bugfixes: user account update, create user #32
Conversation
|
@tuurma I took a look over your PR, thanks for that :-) It looks good, but as far as I can see, it doesn't solve eXist-db/dashboard#93 as claimed. Thoughts? |
modules/userManager.xqm
Outdated
| @@ -167,7 +167,7 @@ declare function usermanager:update-user($user-name as xs:string, $user-json as | |||
| else(), | |||
|
|
|||
| (: if a password is provided, we always change the password, as we dont know what the original password was :) | |||
| for $group in secman:get-user-groups($user) return secman:remove-group-member($group, $user), | |||
| for $group in secman:get-user-groups($user)[. != sm:get-user-primary-group($user)] return secman:remove-group-member($group, $user), | |||
There was a problem hiding this comment.
It might be best to stick with the unusual secman prefix defined in the prolog, or otherwise switch the whole module to the standard sm.
There was a problem hiding this comment.
yeah, it does get on my nerves and, as demonstrated, is easy to make a silly mistake
|
On Monday's Community Call @duncdrum suggested that fixing this issue would be a good opportunity to review #25 (a PR which moves the Cypress integration tests into this repository), update it to reflect the recent changes to the login behavior, and to add a test showing that the fix to this issue has the expected results. |
|
@adamretter correct, didn't read the eXist-db/dashboard#93 title properly: there were two parts to that issue
currently working on proper fix for the second part |
|
@joewiz Thanks, I do realise that it would be ideal to add relevant tests asap |
solves eXist-db/dashboard#93 and eXist-db/dashboard#76