Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(various): prepare gulp builds #606

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(various): prepare gulp builds #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ const prettyData = require('gulp-pretty-data')
const stripBom = require('gulp-stripbom')
const pjson = require('../../package.json')

// Var isodate = (new Date()).toISOString();

// Potential location for teipub defaults. see https://github.com/enquirer/enquirer/issues/15
module.exports = class extends Generator {
initializing () {
this.props = {}
Expand Down Expand Up @@ -77,10 +74,10 @@ module.exports = class extends Generator {
value: ['empty', 'library']
}]
},
// TODO: [yo] Make these options meaningful
// TODO: [gulp] line-o promp user for build system
// {
// type: 'checkbox',
// choices: ['ant', 'gulp', 'maven', 'gradle'],
// choices: ['ant', 'gulp'],
// name: 'builder',
// message: 'How would you like to build your app?',
// default: 'ant'
Expand Down Expand Up @@ -330,7 +327,7 @@ module.exports = class extends Generator {
}]

// TODO: [yo]: js, css, gulp, funcdoc,
// TODO: [gulp] https://github.com/bnjjj/generator-gulpfile-advanced
// TODO: TODO: [gulp] line-o we could also extend this module https://github.com/bnjjj/generator-gulpfile-advanced

return this.prompt(prompts).then(props => {
// To access props later use this.props.someAnswer;
Expand Down Expand Up @@ -403,6 +400,7 @@ module.exports = class extends Generator {
}
// TODO #56 html -> xhtml
// Applies to all (build, expath-pkg, repo, xqs)
// TODO: [gulp] line-o here build.xml is copied for all outputs by default needs to become conditional
this.fs.copyTpl(
this.templatePath('build.xml'),
this.destinationPath('build.xml'), {
Expand Down Expand Up @@ -809,6 +807,7 @@ module.exports = class extends Generator {
this.spawnCommandSync('git', ['add', '--all'])
this.spawnCommandSync('git', ['commit', '-q', '-m', '\'initial scaffolding by Yeoman\''])
}
// TODO: [gulp] line-o make conditional on selected build tool
this.spawnCommandSync('ant', '-q')

console.log(yosay('I believe we\'re done here.'))
Expand Down
5 changes: 5 additions & 0 deletions generators/app/templates/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// TODO: line-o tell me what you want what you really really …
// see https://docs.google.com/document/d/1UdSWERC9rCSYIYjTGgCr3avce47h5OeLFR4tGKYXZlM/edit#heading=h.ei4sqy3ojpkl
// see https://github.com/line-o/gulp-exist-example/blob/main/gulpfile.js
// see https://github.com/eXist-db/documentation/blob/master/Gulpfile.js
// see #563
2 changes: 2 additions & 0 deletions test/generated-pkg/app-empty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const fs = require('fs-extra')

describe('empty package', function () {
this.timeout(15000)
// TODO: #563 [gulp] line-o let's make this the test application for pure gulp build
// We should also add a app-lib-gulp.js test package.
before(async function () {
await helpers.run(path.join(__dirname, '../../generators/app'))
.withPrompts({
Expand Down