Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat-multi-arch-containers #5533

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Feat-multi-arch-containers #5533

merged 7 commits into from
Dec 13, 2024

Conversation

duncdrum
Copy link
Contributor

@duncdrum duncdrum commented Nov 2, 2024 •
edited
Loading

enables a long overdue feature: multi-arch containers for existdb/existdb
backport will remove a release blocker for 6.3.1

sidessteps docker maven plugin bug, deploy is green again.
see fabric8io/docker-maven-plugin#1835

fixes outdated JRE patches, bumps base image to Debian 12
see #5450
close #4151
close #5532
close #4153

@duncdrum duncdrum added the docker issues related to our container images label Nov 2, 2024
@duncdrum duncdrum added this to the eXist-6.3.1 milestone Nov 2, 2024
@duncdrum duncdrum force-pushed the feat-multi-arch-containers branch from e453994 to 75981d8 Compare November 2, 2024 12:35
@duncdrum
Copy link
Contributor Author

The codacy issue here is pointless. We are trying to generate moving tag latest images. So they are based on latest base images from upstream on purpose

@duncdrum duncdrum force-pushed the feat-multi-arch-containers branch 2 times, most recently from 44ac3cd to edfc10e Compare November 12, 2024 13:03
@duncdrum
Copy link
Contributor Author

Deploy in my fork:

Screenshot 2024-11-12 at 15 49 10

images tested locally, all good.

Screenshot 2024-11-12 at 15 53 21

@duncdrum duncdrum marked this pull request as ready for review November 12, 2024 14:54
@duncdrum duncdrum requested a review from a team as a code owner November 12, 2024 14:54
@dizzzz
Copy link
Member

dizzzz commented Nov 12, 2024

Ubuntu build fails, any idea ?
Don't have a laptop around to check the logs ...

@duncdrum
Copy link
Contributor Author

@dizzzz some timeout with building distribution packages, I restarted it. Pretty sure it's unrelated to the changes in here.

line-o
line-o reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duncdrum is this good to go? Should we wait for the back port to 6.x.x?

@duncdrum
Copy link
Contributor Author

@line-o this is good to go. There are problems with the back port, but I m 99,9% certain that these will not affect the contents of this PR, which also fixes our broken ci.

@line-o
Copy link
Member

line-o commented Nov 18, 2024 •
edited
Loading

@duncdrum would you have the time to edit the commit message of edfc10e

to

[bugfix] workaround to deploy images to dockerhub

fixes #5450

sidesteps [docker maven plugin bug](https://github.com/fabric8io/docker-maven-plugin/issues/1835)

If you do not have time I would volunteer to do this.

@duncdrum
Copy link
Contributor Author

@line-o go ahead I ll be afk a lot this week. Thanks for the help

@line-o line-o mentioned this pull request Nov 19, 2024
Closed
@line-o line-o force-pushed the feat-multi-arch-containers branch from 6f7fff4 to 9b1a3cf Compare November 19, 2024 11:56
@line-o line-o self-requested a review November 19, 2024 12:29
line-o
line-o approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dizzzz
dizzzz approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look OK, as discussed last monday.

@line-o line-o force-pushed the feat-multi-arch-containers branch from 015bdad to e3662b0 Compare December 9, 2024 17:34
@line-o
Copy link
Member

line-o commented Dec 9, 2024

This PR is now good to go as all issues have been addressed.

@duncdrum @line-o
[refactor] remove dead code
5bc3019 
dependencies are part of distroless base image
enable experimental image push for testing
@duncdrum @line-o
[feature] add multi-arch images
4fb0518 
see eXist-db#5450
close eXist-db#4151
close eXist-db#5532
close eXist-db#4153
@duncdrum @line-o
[ignore] bump base image
b1adc4f
@line-o line-o force-pushed the feat-multi-arch-containers branch from e3662b0 to 2d95bd1 Compare December 11, 2024 16:44
@line-o
Copy link
Member

line-o commented Dec 11, 2024

rebased on current develop

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dizzzz
Copy link
Member

dizzzz commented Dec 12, 2024

OK to pull? @line-o @ljo @reinhapa

@line-o
Copy link
Member

line-o commented Dec 12, 2024

@dizzzz yes, from my side

@reinhapa
Copy link
Member

@dizzzz yes, from my side

Go!

@dizzzz dizzzz merged commit 6770707 into eXist-db:develop Dec 13, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhapa reinhapa reinhapa approved these changes

@adamretter adamretter adamretter requested changes

@line-o line-o line-o approved these changes

@dizzzz dizzzz dizzzz approved these changes

Assignees

@duncdrum duncdrum

Labels
docker issues related to our container images needs 6.x.x backport
Projects
None yet
Milestone
eXist-6.3.1
Development

Successfully merging this pull request may close these issues.

[CI] Change docker setup does this need to be there ? [feature] multi-arch docker images
5 participants
@duncdrum @dizzzz @line-o @reinhapa @adamretter