Bump com.ibm.icu:icu4j from 59.1 to 76.1 #5522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
is the failing test
curious this was bumped to 60.2 in df10f50 but the pom wasn't updated? |
|
It is very likely that the returned sequence of available collations changes because of additional ones added through icu4j |
|
Ugh ... so we are either depending on 60.2 or 59.1 ? Am I reading this right? |
|
@dependabot rebase |
Bumps [com.ibm.icu:icu4j](https://github.com/unicode-org/icu) from 59.1 to 76.1. - [Release notes](https://github.com/unicode-org/icu/releases) - [Commits](https://github.com/unicode-org/icu/commits) --- updated-dependencies: - dependency-name: com.ibm.icu:icu4j dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/com.ibm.icu-icu4j-76.1
branch
from
c9cc365 to
c539162
Compare
|
The version of ICU cannot be upgraded as it is needed by Lucene 4.11.4, and the version of Lucene in eXist-db cannot be upgraded as it stands. |
|
@dependabot ignore this dependency |
|
Sorry, only users with push access can use that command. |
|
Just upgrading to 60.2 already reveals a breaking change (collations are no longer two character codes but with proper locales). |
line-o
requested changes
Dec 13, 2024
|
Upgrading to 59.2 works without having to change anything. |
|
When ignoring the first failing test the underlying issue is revealed when updating to a later version of ICU4j |
|
@line-o 59.2 seems good. I still don't understand which version is in use currently. @adamretter ah yes Lucene that makes sense. Do you expect the v60 jars to be actually used or should the version declared in the POM be used? |
|
@duncdrum the version needs to stay the same as it is in 6.x.x for nothing to break |
@adamretter am I correct to assume that updating Lucene would also be an option in order to be ready to use the latest ICU version (but may not be that easy) right? |
|
@reinhapa Yes that is mostly the reason. Updating Lucene in eXist-db is very difficult as the version eXist-db uses is very old. Also I rewrote parts of eXist-db previously to make it meet the XQuery spec for collations. So you would also need to test any change to ICU4j against the XQTS to make sure there are no regressions in that area too. |
@adamretter thanks for the explanation |
|
@dependabot ignore this dependency |
|
OK, I won't notify you about com.ibm.icu:icu4j again, unless you re-open this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps com.ibm.icu:icu4j from 59.1 to 76.1.
Release notes
Sourced from com.ibm.icu:icu4j's releases.
... (truncated)
Commits
Most Recent Ignore Conditions Applied to This Pull Request
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)