Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Make build compatible with Java18 and beyond. #5376

Merged
merged 4 commits into from
Aug 1, 2024
Merged

[bugfix] Make build compatible with Java18 and beyond. #5376

merged 4 commits into from
Aug 1, 2024

Conversation

dizzzz
Copy link
Member

@dizzzz dizzzz commented Jul 28, 2024

@dizzzz dizzzz requested a review from a team as a code owner July 28, 2024 19:57
@dizzzz dizzzz marked this pull request as draft July 29, 2024 09:04
@dizzzz
Update ci-test.yml
b503166 
Prevent overwrite logs
line-o
line-o approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@dizzzz

This comment was marked as outdated.

Sign in to view
@dizzzz

This comment was marked as outdated.

Sign in to view
@dizzzz dizzzz marked this pull request as ready for review July 30, 2024 08:28
@dizzzz dizzzz requested review from reinhapa and a team July 30, 2024 08:29
@dizzzz
Copy link
Member Author

dizzzz commented Jul 30, 2024

for reviewers: the core of the changes is in 4 commits, the remaining two touch a lot of files but is just pending refactoring.

image

@dizzzz dizzzz requested a review from duncdrum July 30, 2024 18:43
@line-o
Copy link
Member

line-o commented Jul 31, 2024 •
edited
Loading

I fear this will will introduce merge conflicts with #5259. @dizzzz could you make sure to either incorporate those commits first or at least leave those files alone. We all - @reinhapa, @dizzz and me - did invest quite some time in this already.

@dizzzz

This comment was marked as outdated.

Sign in to view
@line-o
Copy link
Member

line-o commented Jul 31, 2024

@dizzzz git rebase -i would be my tool of choice. This can either drop the commits entirely or lets you edit the two.

Rebasing your changes on top of my commits is also an option.

@dizzzz dizzzz force-pushed the feature/make_build_java18compatible branch from 3690d42 to 394e4aa Compare July 31, 2024 17:46
@dizzzz
Copy link
Member Author

dizzzz commented Jul 31, 2024

@line-o I think I addressed the issue

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dizzzz dizzzz requested a review from reinhapa July 31, 2024 18:44
@dizzzz dizzzz dismissed reinhapa’s stale review July 31, 2024 18:56

not relevant anymore

@reinhapa reinhapa merged commit dbab993 into eXist-db:develop Aug 1, 2024
22 of 24 checks passed
@dizzzz dizzzz mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

@reinhapa reinhapa reinhapa approved these changes

@line-o line-o line-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with Java 21 fails due to ancient Antlr plugin
4 participants
@dizzzz @line-o @reinhapa @duncdrum