Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x.x] Backport build scripts #5091

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[6.x.x] Backport build scripts #5091

merged 2 commits into from
Nov 6, 2023

Conversation

reinhapa
Copy link
Member

Backport develop Github actions

@reinhapa reinhapa changed the base branch from develop to develop-6.x.x October 16, 2023 18:20
@reinhapa reinhapa force-pushed the backport-build branch 3 times, most recently from aade882 to 9964185 Compare October 23, 2023 17:54
dizzzz
dizzzz reviewed Oct 23, 2023
View reviewed changes
exist-parent/pom.xml Outdated Show resolved Hide resolved
@reinhapa reinhapa marked this pull request as ready for review November 3, 2023 17:22
@reinhapa
Copy link
Member Author

reinhapa commented Nov 3, 2023

@dizzzz just squashed all changes together. Ready to merge.

@adamretter
Copy link
Contributor

@reinhapa I am not sure why but it seems to show that none of the CI is running for this, could you take a look please?

@reinhapa
Copy link
Member Author

reinhapa commented Nov 6, 2023

@reinhapa I am not sure why but it seems to show that none of the CI is running for this, could you take a look please?

@adamretter I have no idea. It went into this state, when I squashed the commits together...

@reinhapa reinhapa requested a review from adamretter November 6, 2023 14:48
@reinhapa
[ci] backport github actions
5ccff99 
Also adds missing stylesheet & update xqts version to match

Signed-off-by: Patrick Reinhart <[email protected]>
@reinhapa
[ci] Use same timeouts as develop
9ed64ee 
Signed-off-by: Patrick Reinhart <[email protected]>
@dizzzz
Copy link
Member

dizzzz commented Nov 6, 2023

image

@reinhapa reinhapa requested a review from line-o November 6, 2023 19:25
@dizzzz dizzzz requested a review from a team November 6, 2023 19:25
line-o
line-o approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @reinhapa
Now we will have to monitor if the windows build is really broken at the moment

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@adamretter adamretter merged commit c5c1a0d into eXist-db:develop-6.x.x Nov 6, 2023
11 checks passed
@reinhapa reinhapa deleted the backport-build branch November 7, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz approved these changes

@line-o line-o line-o approved these changes

@adamretter adamretter Awaiting requested review from adamretter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reinhapa @adamretter @dizzzz @line-o