Refactor to highlight materialization query execution model #5079
Conversation
adamretter
force-pushed
the
refactor/query-materialization
branch
from
be5ac32 to
9af416b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
What is this PR wants to highlight. It is not immediately clear to me from its description. @adamretter could you clarify that? |
@line-o It highlights where the Marterialization Query Execution Model is used. |
| * | ||
| * @throws XPathException if an error occurs during evaluation. | ||
| */ | ||
| Sequence eval(@Nullable Sequence contextSequence, @Nullable Item contextItem) throws XPathException; |
There was a problem hiding this comment.
I wonder why you did not choose to have two method definitions, where the second one could have just one parameter (internally using null). this would have avoided a lot of small code changes?
There was a problem hiding this comment.
@dizzzz That is what we had previously. I wanted to simplify this so that there was a single clean interface.
There was a problem hiding this comment.
I miss.... where is this interface used?
There was a problem hiding this comment.
…ion for de-composition of interfaces
…pressions use the Materialization query execution model
adamretter
force-pushed
the
refactor/query-materialization
branch
from
9af416b to
7b80363
Compare
|
Thanks you @dizzzz :-) |
|
@dizzz I wonder why this was merged even though 5 checks are failing. |
|
I merged as the issues were not unique to this branch. |
Backported from FusionDB - Just some small cleanup and refactoring to make future changes easier. Should not break any backwards compatibility or change anything in execution.