-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to plugins/browsing. #25
base: master
Are you sure you want to change the base?
Conversation
Changed inputs to readonly: Resource, Created, Last Modified. Changed to Select: Owner, Group (live lists of available Users and Groups are loaded from the db as needed) Added empty item to Access Control List (to overcome problem when no ACL is present) Modified "Save" button action so that changes to Owner, Group and Mime are now also saved.
Bring my branch up to date.
I am not sure I am the right person to review the change. maybe @windauer or @wolfgangmm or @ljo ? it does look good, but I could not judge.... |
From what I see on the first view it looks good but I haven't tested it. |
@gspringtech Thank you for this submission, and I'm sorry it wasn't acted on. Development energies have shifted to dashboard 2.0. Before I close this PR (since surely the underlying code won't work in 2.0), I believe we need to investigate whether a similar improvement is needed in 2.0 or whether it already implements this idea. |
@eXist-db/xquery-contributors Would anyone be available to check the new dashboard to see if this idea is applicable there? If so, we should close this and start a new issue reiterating the requirements, so that the feature can be added to the new dashboard. |
@joewiz This PR builds on a former version of the dashboard and is no longer applicable. |
I wanted to have Select boxes for Owner and Group - also noticed that changes to Owner and Group weren't being save.
Changed inputs to readonly: Resource, Created, Last Modified.
Changed to Select: Owner, Group (live lists of available Users and Groups are loaded from the db as needed)
Added empty item to Access Control List (to overcome problem when no ACL is present)
Modified "Save" button action so that changes to Owner, Group and Mime are now also saved.