[22317] Test service node listener #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Gil Aviles <[email protected]>
Javgilavi
changed the title
Signed-off-by: Javier Gil Aviles <[email protected]>
Javgilavi
force-pushed
the
test/service_node_listener
branch
from
c0460e3 to
4de5353
Compare
Signed-off-by: Javier Gil Aviles <[email protected]>
Signed-off-by: Javier Gil Aviles <[email protected]>
Mario-DL
requested changes
Jan 22, 2025
sustainml_cpp/include/sustainml_cpp/core/RequestReplyListener.hpp
Outdated
Show resolved
Hide resolved
sustainml_cpp/include/sustainml_cpp/core/RequestReplyListener.hpp
Outdated
Show resolved
Hide resolved
sustainml_cpp/include/sustainml_cpp/nodes/AppRequirementsNode.hpp
Outdated
Show resolved
Hide resolved
| /** | ||
| * @brief This method sends a request to node via service for changing its configuration. | ||
| * @param [in] req configuration request, contain which node and configuration file | ||
| * @param [out] res response from the node with its new configuration |
There was a problem hiding this comment.
With the last update, this line should be removed and specify the return instead
There was a problem hiding this comment.
I think this suggestion was not applied, I am missing the return in the doxygen comment
sustainml_cpp/test/blackbox/common/BlackboxTestsResponseNodes.cpp
Outdated
Show resolved
Hide resolved
sustainml_cpp/test/blackbox/common/BlackboxTestsResponseNodes.cpp
Outdated
Show resolved
Hide resolved
|
Additionally, we should uncrustify the |
Signed-off-by: Javier Gil Aviles <[email protected]>
Mario-DL
requested changes
Jan 23, 2025
sustainml_cpp/include/sustainml_cpp/core/RequestReplyListener.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Javier Gil Aviles <[email protected]>
Javgilavi
force-pushed
the
test/service_node_listener
branch
from
4a18663 to
d73e7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the blackbox tests for service node listener and the minimum needed implementation.