Fix wait_session_status listen timeout #322
Conversation
Signed-off-by: acuadros95 <[email protected]>
|
Build status:
|
|
Build status:
|
Signed-off-by: acuadros95 <[email protected]>
|
Build status:
|
| do | ||
| { | ||
| listen_message(session, remaining_time); | ||
| remaining_time = UXR_CONFIG_MIN_SESSION_CONNECTION_INTERVAL - (int)(uxr_millis() - start_timestamp); |
There was a problem hiding this comment.
This causes invalid underflow when the uxr_millis() returns something invalid, such as the embedded device does not have GPS time yet. I could use some info on how this is being used internally. Our embedded device has multiple time sources. The boot time is what we used to fix this bug, however that does not comply with using ROS2 time (UTC). If we switch time sources at runtime, it would be good to know what to do (from boot time to RTC time).
There was a problem hiding this comment.
Which implementation of uxr_millis() are you using?
There was a problem hiding this comment.
Our software runs on multiple OS's. This one is ChibiOS, so we had to write our own implentation of uxr_millis(). It was not clear from the public API on the requirements for that function. I filed this bug for more info:
#350
Fix wait session timeout and discards any message until create session response.