-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21886] Feature: Windows ci example testing (backport #5397) #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of 9c9078f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
* Refs #21886: Bump windows ci image to 2022 Signed-off-by: Mario-DL <[email protected]> * Refs #21886: Add FASTDDS_EXAMPLE_TESTS=ON for windows ci tests Signed-off-by: Mario-DL <[email protected]> * Refs #21886: Add matched argument to hello_world example Signed-off-by: Mario Dominguez <[email protected]> * Refs #21886: Add Windows testing Dockerfile Signed-off-by: Mario-DL <[email protected]> * Refs #21886: Refactor CMakeLists example tests and hello_world compose Signed-off-by: Mario-DL <[email protected]> * Refs #21886: test_hello_world.py fix Signed-off-by: Mario-DL <[email protected]> * Refs #21886: Update docker compose file structure of the rest of examples Signed-off-by: Mario Dominguez <[email protected]> * Refs #21886: versions.md Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario-DL <[email protected]> Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
mergify/bp/3.0.x/pr-5397
branch
from
December 16, 2024 15:46
b41e49a
to
09c93cb
Compare
Mario-DL
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Mario-DL
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces example testing in windows (for the moment, just the
hello_world_example
) byDockerfile
hello_world
examplematched
so the publisher does not start publishing until it has discovered a minimum of participants.Follow up work
@Mergifyio backport 3.1.x 3.0.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5397 done by [Mergify](https://mergify.com).