Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22285] Fix comparison in is_update_allowed #5414

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[22285] Fix comparison in is_update_allowed #5414

merged 3 commits into from
Nov 25, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 22, 2024 •
edited
Loading

Description

This fixes a bug in the comparison of the security attributes inside is_update_allowed of ReaderProxyData and WriterProxyData.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the needs-review PR that is ready to be reviewed label Nov 22, 2024
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Nov 22, 2024
Mario-DL
Mario-DL approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL Mario-DL self-requested a review November 25, 2024 10:36
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 25, 2024
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 6b74b0d into master Nov 25, 2024
17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/19927 branch November 25, 2024 16:16
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@MiguelCompany @mergify
Fix comparison in is_update_allowed (#5414)
956be59 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
12 tasks
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@MiguelCompany @mergify
Fix comparison in is_update_allowed (#5414)
59f9fdc 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@MiguelCompany @mergify
Fix comparison in is_update_allowed (#5414)
003d31a 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)
This was referenced Nov 25, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@MiguelCompany @mergify
Fix comparison in is_update_allowed (#5414)
63147d6 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Open
12 tasks
MiguelCompany added a commit that referenced this pull request Dec 3, 2024
@mergify @MiguelCompany
Fix comparison in is_update_allowed (#5414) (#5417)
3b3475d 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)

Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Dec 11, 2024
@mergify @MiguelCompany
Fix comparison in is_update_allowed (#5414) (#5415)
ffca0ce 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)

Co-authored-by: Miguel Company <[email protected]>
EugenioCollado pushed a commit that referenced this pull request Dec 30, 2024
@MiguelCompany @EugenioCollado
Fix comparison in is_update_allowed (#5414)
60fcd9f 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)
EugenioCollado pushed a commit that referenced this pull request Dec 31, 2024
@mergify @MiguelCompany
Fix comparison in is_update_allowed (#5414) (#5416)
c8bcb69 
* Refs #19927. Add unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in ReaderProxyData.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19927. Fix issue in WriterProxyData.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 6b74b0d)

Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Awaiting requested review from Mario-DL

Assignees
No one assigned
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL