-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21638] Be less strict with parameter lengths #5225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
previously approved these changes
Sep 19, 2024
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
bugfix/21537
branch
from
September 19, 2024 10:11
9c73e1d
to
8115cfa
Compare
richiware
approved these changes
Sep 19, 2024
@Mergifyio backport 2.14.x 2.10.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp # test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
11 tasks
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Sep 20, 2024
MiguelCompany
added a commit
that referenced
this pull request
Oct 28, 2024
* Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp # test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
MiguelCompany
added a commit
that referenced
this pull request
Nov 4, 2024
* Be less strict with parameter lengths (#5225) * Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp # test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp * Fix conflicts Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
Nov 20, 2024
* Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp
MiguelCompany
added a commit
that referenced
this pull request
Nov 20, 2024
* Be less strict with parameter lengths (#5225) * Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <[email protected]> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp * Refs #21638: Fix conflicts Signed-off-by: JesusPoderoso <[email protected]> * Fix unit tests build Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interoperability checks with Intercom DDS surfaced an issue in the deserializer for builtin topics.
The deserializer expects the parameters in the parameter list to be exactly the expected length.
Debug showed that Intercom DDS is sending a reliability parameter longer than expected, and their DATA(r) and DATA(w) messages were discarded due to a deserialization error.
This PR:
@Mergifyio backport 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist