Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21397] Parse IDL string for xtypes #4943

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

[21397] Parse IDL string for xtypes #4943

wants to merge 40 commits into from
+5,403 −7

Conversation

YangboLong
Copy link
Contributor

@YangboLong YangboLong commented Jun 13, 2024 •
edited by MiguelCompany
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 21, 2024
@elianalf elianalf added needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024
@EduPonz EduPonz modified the milestones: v3.0.0, v3.0.1 Jul 19, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title Parse IDL string for xtypes [21397] Parse IDL string for xtypes Jul 22, 2024
@juanlofer-eprosima juanlofer-eprosima modified the milestones: v3.0.1, v3.0.0 Jul 22, 2024
richiware
richiware requested changes Jul 26, 2024
View reviewed changes
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
examples/cpp/dds/IdlParserExample/IdlParser_main.cpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/dynamic_types/DynamicTypeBuilderFactory.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
@richiware
Copy link
Member

Review current state. Next should be the testing.

@rsanchez15 rsanchez15 modified the milestones: v3.0.1, v3.1.0 Sep 4, 2024
@rsanchez15 rsanchez15 modified the milestones: v3.1.0, v3.2.0 Oct 3, 2024
@YangboLong YangboLong requested a review from richiware October 13, 2024 02:36
@rsanchez15 rsanchez15 mentioned this pull request Nov 25, 2024
Merged
4 tasks
@MiguelCompany MiguelCompany self-requested a review November 29, 2024 12:02
@YangboLong
Test relative_path_include.idl
36c3f3d 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Start to test unions.idl
32b4595 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Fix union case label parsing
ee564a4 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Finish unions.idl testing
43775b4 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Fix internal error spews
d77f98b 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Try fixing ci/cd errors
f5e72a8 
Signed-off-by: Yangbo Long <[email protected]>
@YangboLong
Address PR comments
37687ff 
Signed-off-by: Yangbo Long <[email protected]>
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany January 3, 2025 09:56
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany January 7, 2025 09:39
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany January 7, 2025 11:36
@MiguelCompany MiguelCompany added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed to-do labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@YangboLong @richiware @MiguelCompany @EduPonz @rsanchez15 @elianalf @juanlofer-eprosima