[14091] Fix update remote server locators when enabling statistics #2601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JLBuenoLopez-eProsima [email protected]
Description
If Fast DDS is compile with Statistics (
-DFASTDDS_STATISTICS=ON
) and in Debug, when updating the remote server locator and assertion inOutputTrafficManager::set_statistics_message_data
fails. This is due to the new locator not being added to thecollection_
member of this class. New locators are added when calling to the specific transportOpenOutputChannel
. This PR ensures that it is called before announcing the new Participant state, preventing the assertion to fail.Contributor Checklist
This feature is tested with the tests included in eProsima/Discovery-Server#52. Running these tests with Fast DDS compiled as described before will fail.
Changes does not affect the test suite.
RTPSParticipantImpl::update_attributes
is called in only a few tests. Changes only affect if there are modified locators (if the feature is being used) and this feature is not tested in Fast DDS suite but in the Discovery Server suite.versions.md
file (if applicable).Reviewer Checklist