Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21711] Update DataWriter/Reader get_matched_publication/subscription...() API tests #185

Closed
wants to merge 1 commit into from

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 2, 2024

Description

This PR updates DataWriter/Reader get_matched_publication/subscirption...() tests as result of API implementation:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v1.4.3 milestone Oct 2, 2024
@Mario-DL Mario-DL changed the title [21711] Update DataWriter/Reader get_matched_publication/subscirption...() API tests [21711] Update DataWriter/Reader get_matched_publication/subscription...() API tests Oct 9, 2024
@richiware richiware self-requested a review October 17, 2024 09:07
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 17, 2024
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@Mario-DL
Copy link
Member Author

Mario-DL commented Oct 21, 2024

Tests were failing because we merged the implementation PR and the sibling branch in Fast DDS is no longer available. We would need to manually run it.
In addition, IDK if it is worth to bring the changes from the PR to Fast DDS Python 2.x since I think it is not going to be merged

@Mario-DL
Copy link
Member Author

Manual CI run:
Fast DDS Python Ubuntu CI
Fast DDS Python Windows CI

@Mario-DL
Copy link
Member Author

I am closing this since its implementation entails a behavior change and new majors are not planned for 2.x

@Mario-DL Mario-DL closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants