Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21310] Remove 2.13.x from CI in 1.4.x version #175

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[21310] Remove 2.13.x from CI in 1.4.x version #175

merged 1 commit into from
Jul 23, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 23, 2024 •
edited
Loading

Description

Fast DDS version 2.13.x is EOL. In this PR

It was removed from nightly jobs but the changes performed in this PR was missing in 1.4.x (removing testing with 2.13.x)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v1.4.3 milestone Jul 23, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 23, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 23, 2024
@elianalf
Copy link
Contributor

LGTM with green CI

@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for richiprosima July 23, 2024 09:08
@JesusPoderoso JesusPoderoso merged commit f123d9d into 1.4.x Jul 23, 2024
8 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/eol_2.13.x branch July 23, 2024 09:53
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf Awaiting requested review from elianalf

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @elianalf