Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21383] Fix tests on Ubuntu 24.04 #168

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[21383] Fix tests on Ubuntu 24.04 #168

merged 2 commits into from
Jul 19, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 18, 2024 •
edited by JesusPoderoso
Loading

Description

Running this repository's tests fail on Ubuntu 24.04 due to SWIG 4.1. This PR fixes them.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware requested a review from EduPonz July 18, 2024 06:18
@richiware richiware changed the title Fix tests on Ubuntu 24.04 [21383] Fix tests on Ubuntu 24.04 Jul 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 18, 2024
@EduPonz EduPonz added this to the v2.0.0 milestone Jul 18, 2024
JesusPoderoso
JesusPoderoso suggested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks

fastdds_python/test/api/test_datawriter.py Outdated Show resolved Hide resolved
fastdds_python/test/api/test_datawriter.py Outdated Show resolved Hide resolved
fastdds_python/test/api/test_datareader.py Outdated Show resolved Hide resolved
fastdds_python/test/api/test_subscriber.py Outdated Show resolved Hide resolved
fastdds_python/test/api/test_datareader.py Outdated Show resolved Hide resolved
richiware added 2 commits July 19, 2024 08:16
@richiware
Refs #21382. Fix tests on Ubuntu 24.04
846d225 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21382. Apply suggestions
ddb9b93 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware requested a review from JesusPoderoso July 19, 2024 06:23
JesusPoderoso
JesusPoderoso approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 19, 2024
@richiware richiware merged commit c8278c3 into main Jul 19, 2024
6 checks passed
@richiware richiware deleted the bugfix/21382 branch July 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@EduPonz EduPonz Awaiting requested review from EduPonz

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @JesusPoderoso @EduPonz